[Webkit-unassigned] [Bug 72964] [chromium] Let LayerChromium subclasses override value of opaque() flag. Set it for image, video, and canvas layers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72964





--- Comment #5 from James Robinson <jamesr at chromium.org>  2011-12-01 16:00:44 PST ---
(In reply to comment #4)
> Had insightful conversations with @reveman and @enne, and changing this patch accordingly.
> 
> No longer pushing the opaque stuff back into GraphicsLayer, as maintaining consistency with GraphicsLayer is not deemed correct. Instead, each layer can explicitly control its opaque() flag independently of the GraphicsLayer::contentsOpaque value via a new virtual function LayerChromium::updateOpaque().
> 
> Then set opaque on Image, Video and Canvas layers appropriately. Unit tests for Image and Video included. (Is the Canvas one worth testing? it's pretty simple.)

Canvases are typically *not* opaque. I'm not sure how you would easily test if a canvas were opaque, that's definitely non-trivial.

For video I'm less sure.

I only see logic here for image - did you intend to upload something for canvas/video?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.