[Webkit-unassigned] [Bug 72964] [chromium] Let LayerChromium subclasses override value of opaque() flag. Set it for image, video, and canvas layers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72964


Dana Jansens <danakj at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[chromium] Set opaque on    |[chromium] Let
                   |GraphicsLayer, not          |LayerChromium subclasses
                   |LayerChromium, and ensure   |override value of opaque()
                   |layer is filled opaquely.   |flag. Set it for image,
                   |                            |video, and canvas layers.




--- Comment #4 from Dana Jansens <danakj at chromium.org>  2011-12-01 15:58:07 PST ---
Had insightful conversations with @reveman and @enne, and changing this patch accordingly.

No longer pushing the opaque stuff back into GraphicsLayer, as maintaining consistency with GraphicsLayer is not deemed correct. Instead, each layer can explicitly control its opaque() flag independently of the GraphicsLayer::contentsOpaque value via a new virtual function LayerChromium::updateOpaque().

Then set opaque on Image, Video and Canvas layers appropriately. Unit tests for Image and Video included. (Is the Canvas one worth testing? it's pretty simple.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.