[Webkit-unassigned] [Bug 66756] Implement an Event constructor in V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66756


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105787|review?                     |review+
               Flag|                            |




--- Comment #39 from Adam Barth <abarth at webkit.org>  2011-08-31 11:01:17 PST ---
(From update of attachment 105787)
View in context: https://bugs.webkit.org/attachment.cgi?id=105787&action=review

This looks great.

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:59
> +    if (AllowAllocation::current())
> +        return args.Holder();

Crazy.  Is this a v8 function?  Why does it not require the v8 namespace?  Are we using namespace v8 somewhere?  (We shouldn't be.)

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:75
> +    return toV8(event.release(), args.Holder());

The holder is always the global object.  I guess that makes sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.