[Webkit-unassigned] [Bug 66756] Implement an Event constructor in V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66756


Kentaro Hara <haraken at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105756|1                           |0
        is obsolete|                            |




--- Comment #38 from Kentaro Hara <haraken at google.com>  2011-08-31 10:13:44 PST ---
(From update of attachment 105756)
View in context: https://bugs.webkit.org/attachment.cgi?id=105756&action=review

>> Source/WebCore/ChangeLog:19
>> +        (WebCore::OptionsObject::getKeyValue): Returns a value corresnponding to a given key.
> 
> nit: corresponding

Done.

>> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:37
>> +
> 
> Why is this blank line still here? :P

As I replied in the previous patch, as far as I looked at other files around this file, this blank line is a separator between WebCore headers and V8-specific headers.

>> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:85
>> +     \
> 
> Did Sam’s patch indent the equivalent line one space less? What does check-webkit-style say?

Removed the space. However, check-webkit-style still complains "Code inside a namespace should not be indented.  [whitespace/indent] [4]", even if I remove this blank line. To convince check-webkit-style, we need to remove the leading spaces in the next line ("v8::Handle<v8::Value> V8##EventType::constructorCallback(const v8::Arguments& args) \").

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.