[Webkit-unassigned] [Bug 67289] Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67289





--- Comment #3 from asvitkine at chromium.org  2011-08-31 08:11:59 PST ---
> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:783
> > +        shadowRect.setHeight(kShadowSize);
> 
> I guess the reason you have two calls for the toolbar gradient is because the vertical overhang shadow is always full-height while the horizontal overhang shadow might be smaller.

Correct.

> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:791
> >      // If both rectangles present, draw a radial gradient for the corner.
> 
> I assume you checked that it doesn't look weird that this gets drawn on top of the toolbar shadow :-)

When there's a vertical overhang, the implementation degrades to using additive shadows since it's not really possible to have non-additive shadows in the presence of the corner radial gradient. 

So when the radial gradient is shown, it implies there's a vertical overhang and thus we use additive shadows - so it looks consistent with the horizontal overhang shadows which will also be additive in that case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.