[Webkit-unassigned] [Bug 67289] Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67289





--- Comment #2 from Nico Weber <thakis at chromium.org>  2011-08-31 07:59:07 PST ---
(From update of attachment 105775)
View in context: https://bugs.webkit.org/attachment.cgi?id=105775&action=review

LGTM

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:783
> +        shadowRect.setHeight(kShadowSize);

I guess the reason you have two calls for the toolbar gradient is because the vertical overhang shadow is always full-height while the horizontal overhang shadow might be smaller.

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:791
>      // If both rectangles present, draw a radial gradient for the corner.

I assume you checked that it doesn't look weird that this gets drawn on top of the toolbar shadow :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.