[Webkit-unassigned] [Bug 67012] [EFL] Allow controlling minimum DOMTimer interval on a per-page basis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67012





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-08-30 02:14:36 PST ---
(In reply to comment #4)
> Informal r- for now.
> 
> > Source/WebKit/efl/ewk/ewk_view.h:1874
> > + * Sets the minimum interval for DOMTimers on current page.
> 
> I think you could explain very briefly in the apidox what DOMTimers are.
> 
> > Source/WebKit/efl/ewk/ewk_view.h:1876
> > + * Currently, minimum interval value is 4ms by default. If less minimum interval value is set,
> 
> The whole "If less minimum [...] function more frequently" part is hard to understand -- I couldn't get what the first sentence stood for, and the second one looks redundant.

Ok, it also seems to me second description is not needed. Other ports just also explain very briefly as below links,

https://bugs.webkit.org/attachment.cgi?id=82521&action=diff#Source/WebKit/mac/WebView/WebViewPrivate.h_sec1

https://bugs.webkit.org/attachment.cgi?id=82521&action=diff#Source/WebKit/win/Interfaces/IWebViewPrivate.idl_sec1

So, I remove redundant description.

> 
> > Source/WebKit/efl/ewk/ewk_view.h:1887
> > + * Gets the default interval for DOMTimers on all pages.
> 
> Doesn't it make more sense to return the minimum interval time set for this page? If the apidox for the setter already says the default value is 4ms and you can't change it, there is little point in returning it while not returning the value for the current page.

This patch is to control minimum interval of DOMTimer on per page basis. Because, we don't want that background tab consumes cpu, battery resource on multi tabs browsing. (This is desirable on mobile devices.) So, application only needs to know both default minimum interval for all pages and how to set the minimum interval on specific page. So, I added only two APIs. 

However, as you said, smart data struct maintains setting variables for a page.
I also think it is better to add both an interval variable in smart data struct and minimum_timer_interval_get() for a page. Nevertheless, application still needs to know the default minimum value in order to set default interval again. I move the API to ewk_settings.cpp because that is more proper location.

However, I think we don't need to change default interval. mac, window port don't support to change default timer interval yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.