[Webkit-unassigned] [Bug 67012] [EFL] Allow controlling minimum DOMTimer interval on a per-page basis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67012


Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kubo at profusion.mobi




--- Comment #4 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-08-26 05:50:15 PST ---
Informal r- for now.

> Source/WebKit/efl/ewk/ewk_view.cpp:2349
> +    priv->page_settings->setMinDOMTimerInterval(interval);

The idiom we're currently using for settings is to have a variable in the settings struct in the smart data, so the interaction is first done with it (the same applies to the getter below).

> Source/WebKit/efl/ewk/ewk_view.h:1874
> + * Sets the minimum interval for DOMTimers on current page.

I think you could explain very briefly in the apidox what DOMTimers are.

> Source/WebKit/efl/ewk/ewk_view.h:1876
> + * Currently, minimum interval value is 4ms by default. If less minimum interval value is set,

The whole "If less minimum [...] function more frequently" part is hard to understand -- I couldn't get what the first sentence stood for, and the second one looks redundant.

> Source/WebKit/efl/ewk/ewk_view.h:1887
> + * Gets the default interval for DOMTimers on all pages.

Doesn't it make more sense to return the minimum interval time set for this page? If the apidox for the setter already says the default value is 4ms and you can't change it, there is little point in returning it while not returning the value for the current page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.