[Webkit-unassigned] [Bug 65564] Support for multiple <link rel="icon"> favicon elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65564





--- Comment #19 from Rachel Blum <groby at chromium.org>  2011-08-29 13:45:57 PST ---
(In reply to comment #18)
>  - Overall, sounds like a good plan.

I'll start getting the patch ready, then.

>  - Document::setIconURL should probably be changed to addIconURL since there could be multiple icon URLs, right?

Yes and no. For the pre-defined types of icon (FavIcon, TouchIcon, TouchIconPrecomputed) this will keep existing behavior and just set one icon. I've got no preference either way, since neither name catches the meaning 100%. 

I'll go with the rename for now.

>  - Your document doesn't indicate how the Chromium WebKit API will be impacted.

It isn't :)

Chromium still gets notified via ChromeRenderViewObserver::DidIconChange(), and it obtains a list of icons directly from the IconController.

>  - I tend to agree with you that making Document::iconURL return a Vector is better than introducing a separate allIconURLs function.  (shouldn't iconURL be named iconURLs?)

It probably should. Changing the name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.