[Webkit-unassigned] [Bug 65564] Support for multiple <link rel="icon"> favicon elements.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 29 12:36:16 PDT 2011


--- Comment #18 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-29 12:36:16 PST ---
(In reply to comment #17)
> Proposal for a patch with minimal effect on the current API: https://docs.google.com/document/pub?id=1FbxGOXcwEKIXsh44NESRpgHXYIt1MnCUoqgueZ-_U6Y
> The summary: API's stay mostly the same. Signatures get changed to accomodate sizes where appropriate, and one function changes from returning an IconURL to returning Vector<IconURL> - smallest possible change.
> We do need sizes since the HTML5 spec explicitly allows for them. (And with larger icons, they allow only downloading icons of appropriate size without peeking into every file)

Some comments:

 - Overall, sounds like a good plan.

 - Document::setIconURL should probably be changed to addIconURL since there could be multiple icon URLs, right?

 - Your document doesn't indicate how the Chromium WebKit API will be impacted.

 - I tend to agree with you that making Document::iconURL return a Vector is better than introducing a separate allIconURLs function.  (shouldn't iconURL be named iconURLs?)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list