[Webkit-unassigned] [Bug 66877] [Chromium] Add ability to do static SerializedScriptValue deserialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66877





--- Comment #7 from Greg Billock <gbillock at google.com>  2011-08-29 08:29:54 PST ---
(From update of attachment 105378)
View in context: https://bugs.webkit.org/attachment.cgi?id=105378&action=review

>> Source/WebKit/chromium/public/WebSerializedScriptValue.h:65
>> +    WEBKIT_EXPORT static WebSerializedScriptValue fromValue(v8::Handle<v8::Value>);
> 
> Perhaps it would be better to name this function serialize to parallel the
> deserialize function.  I'm guessing you went with from* to match fromString.
> Maybe the difference there is that fromString is really just taking the
> serialized bytes and storing them in a WebSerializedScriptValue.  It is not
> performing any parsing of the data.

Sounds good. In the WebKit2 version of this, the equivalent for JSC uses a constructor. Shall I just do that?

>> Source/WebKit/chromium/public/WebSerializedScriptValue.h:68
>> +
> 
> nit: only one new line here

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.