[Webkit-unassigned] [Bug 66877] [Chromium] Add ability to do static SerializedScriptValue deserialization

Fri Aug 26 11:27:26 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=66877

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105378|review?                     |review-
               Flag|                            |

--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-26 11:27:27 PST ---
(From update of attachment 105378)
View in context: https://bugs.webkit.org/attachment.cgi?id=105378&action=review

> Source/WebKit/chromium/public/WebSerializedScriptValue.h:65
> +    WEBKIT_EXPORT static WebSerializedScriptValue fromValue(v8::Handle<v8::Value>);

Perhaps it would be better to name this function serialize to parallel the
deserialize function.  I'm guessing you went with from* to match fromString.
Maybe the difference there is that fromString is really just taking the
serialized bytes and storing them in a WebSerializedScriptValue.  It is not
performing any parsing of the data.

> Source/WebKit/chromium/public/WebSerializedScriptValue.h:68
> +

nit: only one new line here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.