[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297





--- Comment #49 from Genisim <genisim at yahoo.com>  2011-08-25 11:17:21 PST ---
Noam,

thanks for comments. Two fixes are easy:

  alphabetical and add notImplemented

fix #3 - split toggleWebInspector on two :

   - enable / disable DeveloperExtras 
   - toggleWebInspector

is not simple as it looks.

 1. At least two features (Web Inspector and WebGL) depends from DeveloperExtras preference. And only for this reason toggleWebInspector must be split.

 2. If user disables DeveloperExtras, and dependent features (WebInspector for exm) are on, we have three choices:
    - note user - "Can't disable DeveloperExtras" because of ...
    - keep DeveloperExtras enable without notification
    - turn of features dependent from DeveloperExtras and after disable DeveloperExtras

 3. If DeveloperExtras features menu is visible (independently on DeveloperExtras preference), QDesktopWebView::toggleWebInspector() before
call inspector functions (isVisible, close, show) must check DeveloperExtras status.
    Otherwise if DeveloperExtras features menu start be visible only after DeveloperExtras enable, we can skip DeveloperExtras status check

 4. QDesktopWebView::enableDeveloperExtras(bool enable) must include additional tests (read point #2) if we decide check and turn off features dependent on DeveloperExtras preference

So, I propose for now split QDesktopWebView::toggleWebInspector on two
 - enableDeveloperExtras(bool)
 - toggleWebInspector
no extra tests. I think we can commit this one and after continue to work on patches related to point #2, #3, #4 and new APIs like toggleWebGL

thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.