[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105110|review?                     |review-
               Flag|                            |




--- Comment #48 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-08-25 07:32:28 PST ---
(From update of attachment 105110)
View in context: https://bugs.webkit.org/attachment.cgi?id=105110&action=review

In general it's going in a good direction. See comments.

>> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:42
>> +#include "WebInspectorProxy.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix.

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:319
> +    if (toImpl(m_inspector)->isVisible()) {
> +        toImpl(m_preferences)->setDeveloperExtrasEnabled(false);
> +        toImpl(m_inspector)->close();
> +    } else {
> +        toImpl(m_preferences)->setDeveloperExtrasEnabled(true);
> +        toImpl(m_inspector)->show();
> +    }

Wouldn't work. You need to separate the developer-extras setting from showing the inspector; otherwise inspector would only collect information from the page while it's shown.

> Source/WebKit2/UIProcess/API/qt/qtouchwebview.cpp:116
> +void QTouchWebView::toggleWebInspector()
> +{
> +}

Maybe add notImplemented() or a FIXME comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.