[Webkit-unassigned] [Bug 66800] [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66800





--- Comment #16 from borenet at gmail.com  2011-08-24 16:00:42 PST ---
(From update of attachment 104998)
View in context: https://bugs.webkit.org/attachment.cgi?id=104998&action=review

>> Source/WebKit/chromium/src/WebInputEventConversion.cpp:395
>> +void AddTouchPoints(TouchList* touches, WebTouchPoint* touchPoints,
> 
> nit: it is more common place in WebKit to just use the 'static' keyword here.
> 
> can touches be declared as const?  'const TouchList*'?
> or, can it be a 'const TouchList&' instead?  it doesn't look like this function
> mutates the TouchList at all, so it should not be passed as a non-const pointer/
> reference.

This could be changed to be const TouchList&, but we get a TouchList* from WebCore::TouchEvent and would have to make local copies in WebTouchEventBuilder().  Compiler complains about const-correctness when calling touches->item(i) if const TouchList* is used.  Without modifying the TouchList class, I'm not sure if a const pointer can be used.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.