[Webkit-unassigned] [Bug 66800] [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66800





--- Comment #15 from borenet at gmail.com  2011-08-24 15:28:43 PST ---
(From update of attachment 104998)
View in context: https://bugs.webkit.org/attachment.cgi?id=104998&action=review

>> Source/WebKit/chromium/public/WebTouchPoint.h:42
>> +        : id(0)
> 
> What values can "id" have if not one of the pre-defined Finger enum values?

'id' is just an integer in both WebCore::Touch and Pepper.  We never do any conversion of ids, and we don't require that the WebTouchPoint id is one of the enum values, so there really isn't much point in having it at all.

>> Source/WebKit/chromium/src/WebInputEventConversion.cpp:404
>> +            touch->pageX() - offset.x(),
> 
> what is the offset used for?  does this represent scroll offset of the frame?  if so,
> does this work properly with iframes?  we normally need to use one of the conversion
> routines like convertToContainingWindow to map from widget coordinates and viewport
> coordinates.

Offset is the DOM (x, y) of the plugin widget.  The expression then results in the touch coordinate being the DOM coordinate within the plugin.  Is there a better method for this?

>> Source/WebKit/chromium/src/WebInputEventConversion.h:130
>> +    WebTouchEventBuilder(const WebCore::Widget*, const WebCore::TouchEvent&);
> 
> no need for WebCore:: prefix

Removing this causes compile errors

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.