[Webkit-unassigned] [Bug 66746] Expose setFullscreen method on WebPluginContainer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66746


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104792|review?                     |review-
               Flag|                            |




--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-23 16:24:38 PST ---
(From update of attachment 104792)
View in context: https://bugs.webkit.org/attachment.cgi?id=104792&action=review

> Source/WebKit/chromium/public/WebPluginContainer.h:93
> +    virtual void setFullscreen(bool) = 0;

Since this is implemented as webkitRequestFullScreen, it could fail.  In other
words, this method should probably have a name indicative of the fact that this
could fail.

Another idea here, is that we could just expose a requestFullScreen function on
WebElement.  WebPluginContainer provides a way to get the WebElement containing
the plugin.  We could also add a cancelFullScreen method on WebElement.  This
might be the better way to expose this functionality to the embedder of WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.