[Webkit-unassigned] [Bug 66746] Expose setFullscreen method on WebPluginContainer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66746





--- Comment #6 from Jeremy Apthorp <jeremya at chromium.org>  2011-08-23 15:25:17 PST ---
(In reply to comment #5)
> (From update of attachment 104792 [details])
> I thought the new fullscreen goodness allowed you to make any element fullscreen?

They do. The reason I put the code in WebPluginContainer instead of WebElement is that WebPluginContainer has a direct reference to a WebCore::HTMLPlugInElement, and it seemed silly to wrap it in WebElement only to unwrap it and call a method on it immediately afterwards.

I think if I moved the function to WebElement, I would mirror the WebKit API, and have:

webelement->requestFullScreen(flags);

and

webelement->document()->cancelFullScreen();

which would necessitate adding 3 methods:
- void WebElement::requestFullScreen(flags)
- WebDocument WebElement::document()
- void WebDocument::cancelFullScreen()


If that seems cleaner/better to someone with a clearer understanding of the WebFoo wrapper APIs than me, I'm happy to reimplement it that way :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.