[Webkit-unassigned] [Bug 53438] Text-overflow is broken for button elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53438





--- Comment #10 from Igor Trindade Oliveira <itrindade.oliveira at gmail.com>  2011-08-22 14:58:27 PST ---
(In reply to comment #9)
> (From update of attachment 104741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104741&action=review
> 
> r-
> 
> > Source/WebCore/rendering/RenderBox.h:346
> > +    virtual bool hasControlClip() const { return parentBox() && parentBox()->hasControlClip() && isAnonymousBlock(); }
> 
> I'd move isAnonymousBlock to be the first condition in the return statement instead of the last.
> 

Ok

> > Source/WebCore/rendering/RenderBox.h:347
> > +    virtual LayoutRect controlClipRect(const IntPoint&) const;
> 
> Don't change the interface here. Should still be layoutpoint.

Sorry, it was the leftover of the last patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.