[Webkit-unassigned] [Bug 53438] Text-overflow is broken for button elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53438


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104741|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Dave Hyatt <hyatt at apple.com>  2011-08-22 14:48:01 PST ---
(From update of attachment 104741)
View in context: https://bugs.webkit.org/attachment.cgi?id=104741&action=review

r-

> Source/WebCore/rendering/RenderBox.h:346
> +    virtual bool hasControlClip() const { return parentBox() && parentBox()->hasControlClip() && isAnonymousBlock(); }

I'd move isAnonymousBlock to be the first condition in the return statement instead of the last.

> Source/WebCore/rendering/RenderBox.h:347
> +    virtual LayoutRect controlClipRect(const IntPoint&) const;

Don't change the interface here. Should still be layoutpoint.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.