[Webkit-unassigned] [Bug 66361] Pass --makeargs of build-webkit to chromium linux builder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66361


Xianzhu Wang <wangxianzhu at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104145|0                           |1
        is obsolete|                            |
 Attachment #104614|                            |review?
               Flag|                            |




--- Comment #7 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-08-19 21:17:41 PST ---
Created an attachment (id=104614)
 --> (https://bugs.webkit.org/attachment.cgi?id=104614&action=review)
new patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104145&action=review

>> Tools/Scripts/webkitdirs.pm:1834
>> +    my $makeArgs = "-j$numCpus";
> 
> Nit: We end up add -j$numCpus below so you don't need to set the value here.

Sorry this was my mistake that I forgot to remove the latter assignment.

>> Tools/Scripts/webkitdirs.pm:1839
>> +    }
> 
> This could be:
> for (@options) {
>    $makeArgs = $1 if /^--makeargs=(.*)/;
> }

Thanks. Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.