[Webkit-unassigned] [Bug 66361] Pass --makeargs of build-webkit to chromium linux builder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66361


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104145|review?                     |review-
               Flag|                            |




--- Comment #6 from Tony Chang <tony at chromium.org>  2011-08-19 09:47:32 PST ---
(From update of attachment 104145)
View in context: https://bugs.webkit.org/attachment.cgi?id=104145&action=review

It seems fine to take this patch since many other ports use --makeargs.

> Tools/Scripts/webkitdirs.pm:1834
> +    my $makeArgs = "-j$numCpus";

Nit: We end up add -j$numCpus below so you don't need to set the value here.

> Tools/Scripts/webkitdirs.pm:1839
> +    for my $i (0 .. $#options) {
> +        if ($options[$i] =~ /^--makeargs=(.*)/i ) {
> +            $makeArgs = $1;
> +        }
> +    }

This could be:
for (@options) {
   $makeArgs = $1 if /^--makeargs=(.*)/;
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.