[Webkit-unassigned] [Bug 66288] Selecting all and inserting text into a page with a frameset leads to a NULL ptr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 11:04:16 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66288





--- Comment #6 from Eric Seidel <eric at webkit.org>  2011-08-17 11:04:16 PST ---
(From update of attachment 104187)
View in context: https://bugs.webkit.org/attachment.cgi?id=104187&action=review

> Source/WebCore/editing/InsertTextCommand.cpp:111
> +        // deleteSelection may clobber the endingSelection due to some validation wackiness in VisibleSelection.

Can you be more descriptive than "wackiness"?  Maybe link to a bug about said wackiness?

I appreciate the extra comment, btw.  The goal here would be to understand why this code is here, and under what conditions we should remove it.  If there are no conditions, then we just need to understand the "why" which you gave, but in somewhat imprecise terms.  You certainly can link to this bug for more info if you'd rather too.

This is a total trivial nit, but I'm unfamiliar with this code and your comment is helping me better understand what you're doing. :)

Thank you!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list