[Webkit-unassigned] [Bug 66288] Selecting all and inserting text into a page with a frameset leads to a NULL ptr

Wed Aug 17 11:01:55 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=66288

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104187|review?                     |review+
               Flag|                            |

--- Comment #5 from Tony Chang <tony at chromium.org>  2011-08-17 11:01:55 PST ---
(From update of attachment 104187)
View in context: https://bugs.webkit.org/attachment.cgi?id=104187&action=review

> LayoutTests/editing/inserting/insert-text-into-empty-frameset-crash.html:1
> +<html>

Nit: <DOCTYPE html>

> Source/WebCore/editing/InsertTextCommand.cpp:110
>          deleteSelection(false, true, true, false);

Wow, this function should take enums rather than 4 bools. (Unrelated to your patch, but would be a good place for a refactoring patch.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.