[Webkit-unassigned] [Bug 60529] Programmatically set selection should not have direction on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60529





--- Comment #59 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-10 16:27:11 PST ---
(From update of attachment 103518)
View in context: https://bugs.webkit.org/attachment.cgi?id=103518&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:909
> -    setEndingSelection(VisibleSelection(start, end, DOWNSTREAM));
> +    setEndingSelection(VisibleSelection(start, end, DOWNSTREAM, endingSelection().isDirectional()));

I don't think it makes any sense for us to preserve ending selection's direction here.  If anything, we should be passing true because start and end are literally nothing to do with endingSelection.

> Source/WebCore/editing/CompositeEditCommand.cpp:1010
> -    setEndingSelection(VisibleSelection(start, end, DOWNSTREAM));
> +    setEndingSelection(VisibleSelection(start, end, DOWNSTREAM, endingSelection().isDirectional()));

Ditto.

> Source/WebCore/editing/CompositeEditCommand.cpp:1037
> -    setEndingSelection(destination);
> +    setEndingSelection(VisibleSelection(destination, endingSelection().isDirectional()));

Ditto.

> Source/WebCore/editing/FrameSelection.cpp:859
> +    m_selection.setIsDirectional(shouldAlwaysUseDirectionalSelection(m_frame) || alter == AlterationExtend);

I'd like to see the rationale for moving this statement in the change log.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.