[Webkit-unassigned] [Bug 60529] Programmatically set selection should not have direction on Mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 16:03:08 PDT 2011


--- Comment #58 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-10 16:03:08 PST ---
(From update of attachment 103518)
View in context: https://bugs.webkit.org/attachment.cgi?id=103518&action=review

> Source/WebCore/dom/Element.cpp:1677
> -        VisibleSelection newSelection = VisibleSelection(firstPositionInOrBeforeNode(this), DOWNSTREAM);
> +        VisibleSelection newSelection = VisibleSelection(firstPositionInOrBeforeNode(this), DOWNSTREAM, frame->selection()->selection().isDirectional());

I don't think we should be preserving isDirectional here because we're creating new selection.  Is there any test that proves otherwise?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list