[Webkit-unassigned] [Bug 55455] [EFL] HTML saving feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55455





--- Comment #34 from Grzegorz <g.czajkowski at samsung.com>  2011-08-08 23:41:25 PST ---
(In reply to comment #33)
> (From update of attachment 103233 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103233&action=review
> 
> cpp files should go into WebKit coding style and public headers with toolkit coding style, no?

Thanks for your review.
There were commits which move the pointer operator to variable according to EFL coding style for all WebKit-EFL's files. For instance, commit for ewk_frame https://bugs.webkit.org/show_bug.cgi?id=65357

So I adjusted this patch to these changes.

> 
> Based on that some comments...
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1495
> > +    *frame_source = 0; // Saves 0 to pointer until it's not allocated.
> 
> frameSource?

This is the pointer where to store source of frame which is given through parameter:
EAPI ssize_t ewk_frame_source_get(Evas_Object *o, char **frame_source);
Generally API exposed by WebKit-EFL uses names separated by underline.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1504
> > +    WebCore::Node *documentNode = sd->frame->document()->documentElement();
> 
> * position

EFL's coding style.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1508
> > +                WebCore::HTMLElement *element = static_cast<WebCore::HTMLElement*>(node);
> 
> Ditto.

EFL's coding style.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1532
> > +    (*frame_source)[source_length] = '\0';
> 
> who deletes "frame_source"?

Caller should delete "frame_Source". It's mentioned in doxygen description.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1537
> > +Eina_List *ewk_frame_resources_location_get(Evas_Object *o)
> 
> * position

EFL's coding style.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1543
> > +    Eina_List *listOfImagesLocation = 0;
> 
> Ditto.

EFL's coding style.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1554
> > +        Eina_List *listIterator = 0;
> 
> Ditto

EFL's coding style.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1555
> > +        void *data = 0;
> 
> Ditto

EFL's coding style.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1563
> > +        char *imageLocationCopy = strdup(imageLocation.utf8().data());
> 
> Ditto

EFL's coding style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.