[Webkit-unassigned] [Bug 55455] [EFL] HTML saving feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55455





--- Comment #33 from Antonio Gomes <tonikitoo at webkit.org>  2011-08-08 10:21:29 PST ---
(From update of attachment 103233)
View in context: https://bugs.webkit.org/attachment.cgi?id=103233&action=review

cpp files should go into WebKit coding style and public headers with toolkit coding style, no?

Based on that some comments...

> Source/WebKit/efl/ewk/ewk_frame.cpp:1495
> +    *frame_source = 0; // Saves 0 to pointer until it's not allocated.

frameSource?

> Source/WebKit/efl/ewk/ewk_frame.cpp:1504
> +    WebCore::Node *documentNode = sd->frame->document()->documentElement();

* position

> Source/WebKit/efl/ewk/ewk_frame.cpp:1508
> +                WebCore::HTMLElement *element = static_cast<WebCore::HTMLElement*>(node);

Ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1532
> +    (*frame_source)[source_length] = '\0';

who deletes "frame_source"?

> Source/WebKit/efl/ewk/ewk_frame.cpp:1537
> +Eina_List *ewk_frame_resources_location_get(Evas_Object *o)

* position

> Source/WebKit/efl/ewk/ewk_frame.cpp:1543
> +    Eina_List *listOfImagesLocation = 0;

Ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1554
> +        Eina_List *listIterator = 0;

Ditto

> Source/WebKit/efl/ewk/ewk_frame.cpp:1555
> +        void *data = 0;

Ditto

> Source/WebKit/efl/ewk/ewk_frame.cpp:1563
> +        char *imageLocationCopy = strdup(imageLocation.utf8().data());

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.