[Webkit-unassigned] [Bug 65088] Intel Compiler on windows fails to build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65088





--- Comment #14 from Aron Rosenberg <arosenberg at logitech.com>  2011-08-05 13:36:44 PST ---
(In reply to comment #13)
> 
> > Source/JavaScriptCore/wtf/ByteArray.h:94
> > +#if COMPILER(MSVC) && !COMPILER(INTEL)
> 
> You mean COMPILER(MSVC) is true for the Intel compiler??? That is really weird.
The Intel compiler identifies itself as MSVC as well as Intel on Windows based upon which version of MSVC it's paired with.
> 
> > Source/JavaScriptCore/wtf/NullPtr.h:38
> > +#if __has_feature(cxx_nullptr) || (GCC_VERSION_AT_LEAST(4, 6, 0) && defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) && _MSC_VER >= 1600 && !COMPILER(INTEL))
> 
> The AND make the whole line harder to read and look suspicious.
> Why not || !COMPILER(INTEL)?
> 
See above about the paired identity

> > Source/WebKit.pri:160
> > +win32-icc: QMAKE_CXXFLAGS += -wd873
> 
> You must add an explanation for this in the changelog.
Will do

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.