[Webkit-unassigned] [Bug 65088] Intel Compiler on windows fails to build

Fri Aug 5 13:25:14 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65088

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102469|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #13 from Benjamin Poulain <benjamin at webkit.org>  2011-08-05 13:25:14 PST ---
(From update of attachment 102469)
View in context: https://bugs.webkit.org/attachment.cgi?id=102469&action=review

> ChangeLog:4
> +
> +        Reviewed by Yael Aharon.
> +

Uh???

> Source/JavaScriptCore/wtf/ByteArray.h:94
> +#if COMPILER(MSVC) && !COMPILER(INTEL)

You mean COMPILER(MSVC) is true for the Intel compiler??? That is really weird.

> Source/JavaScriptCore/wtf/NullPtr.h:38
> +#if __has_feature(cxx_nullptr) || (GCC_VERSION_AT_LEAST(4, 6, 0) && defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) && _MSC_VER >= 1600 && !COMPILER(INTEL))

The AND make the whole line harder to read and look suspicious.
Why not || !COMPILER(INTEL)?

> Source/WebKit.pri:160
> +win32-icc: QMAKE_CXXFLAGS += -wd873

You must add an explanation for this in the changelog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.