[Webkit-unassigned] [Bug 48483] Get rid of ResourceRequestBase::m_targetType

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 13:05:15 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=48483





--- Comment #14 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-02 13:05:15 PST ---
(In reply to comment #13)
> How would you get that information from the point of where the ResourceRequest is created to FrameLoaderClient::willSendRequest. Add it to the options used to create the loader?

I'm not sure.  Maybe we would need to create a wrapper for ResourceRequest that WebCore can use whenever it constructs a ResourceRequest.  That would probably be the most robust way to plumb this (as opposed to adding another parameter to a zillion functions).

We have FrameLoadRequest, which I'm sure everyone hates, and my proposal would be to add another thing like that, but what else can you do?  If ResourceRequest is supposed to be low-level, then WebCore needs some higher-level wrapper to construct whenever it wants to make a ResourceRequest.  Maybe call it LoadRequest to be ultra-confusing but at least somewhat related to FrameLoadRequest?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list