[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60439





--- Comment #63 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-08-01 07:54:17 PST ---
(In reply to comment #62)
> (In reply to comment #60)
> > Committed r86276: <http://trac.webkit.org/changeset/86276>
> 
> In this commit, was there a review for 
> "Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation"? I don't see it.
Some of this was reviewed offline.

> 
> 
> The following is changed without explanation and I don't see it in the comments:
> -GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, m_dirtyRect.x(), m_dirtyRect.y(), m_dirtyRect.width(), m_dirtyRect.height(), GL_RGBA, GL_UNSIGNED_BYTE, m_buffer->data())) 
> +GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, m_dirtyRect.x(), m_dirtyRect.y(), m_dirtyRect.width(), m_dirtyRect.height(), GL_BGRA, GL_UNSIGNED_BYTE, m_buffer->data())) 
> 
> 
> The annoying part being GL_BGRA does not exist on OpenGL ES (see http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexImage2D.xml) so this does not compile on ARM anymore.
> 
> The use of the format BGRA is kind of mysterious since the buffer is a RGBA32PremultimpliedBuffer.
> The format + the fact that the original data is premultiplied makes BitmapTextureGL::endPaint() pretty mysterious without explanations :)

We need to add a software based RGBA->BGRA for platforms that don't support it, or put it in the shader.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.