[Webkit-unassigned] [Bug 60439] [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 05:25:31 PDT 2011


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |benjamin at webkit.org

--- Comment #62 from Benjamin Poulain <benjamin at webkit.org>  2011-08-01 05:25:30 PST ---
(In reply to comment #60)
> Committed r86276: <http://trac.webkit.org/changeset/86276>

In this commit, was there a review for 
"Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation"? I don't see it.

The following is changed without explanation and I don't see it in the comments:
-GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, m_dirtyRect.x(), m_dirtyRect.y(), m_dirtyRect.width(), m_dirtyRect.height(), GL_RGBA, GL_UNSIGNED_BYTE, m_buffer->data())) 
+GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, m_dirtyRect.x(), m_dirtyRect.y(), m_dirtyRect.width(), m_dirtyRect.height(), GL_BGRA, GL_UNSIGNED_BYTE, m_buffer->data())) 

The annoying part being GL_BGRA does not exist on OpenGL ES (see http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexImage2D.xml) so this does not compile on ARM anymore.

The use of the format BGRA is kind of mysterious since the buffer is a RGBA32PremultimpliedBuffer.
The format + the fact that the original data is premultiplied makes BitmapTextureGL::endPaint() pretty mysterious without explanations :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list