[Webkit-unassigned] [Bug 58416] [GTK] Implement UI client in minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58416





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-04-27 05:47:08 PST ---
(In reply to comment #5)
> (From update of attachment 89760 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89760&action=review
> 
> Looks good, but please fix the style errors before landing.
> 
> > Tools/MiniBrowser/gtk/BrowserWindow.c:406
> > +static void browserWindowUIClientInit(BrowserWindow* window)
> 
> Please shift the asterisk over.

Ok, I thought the style was the same for non-C++ files, sorry.

> > Tools/MiniBrowser/gtk/main.c:32
> > +static const gchar** uriArguments = NULL;
> 
> The asterisks should be on uriArguments.
> 
> > Tools/MiniBrowser/gtk/main.c:48
> > +    GtkWidget* mainWindow = browser_window_new(webView);
> > +    gchar* url = argumentToURL(uri);
> > +    WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithUTF8CString(url));
> 
> Ditto
> 
> > Tools/MiniBrowser/gtk/main.c:66
> > +    GOptionContext* context = g_option_context_new(NULL);
> 
> Ditto
> 
> > Tools/MiniBrowser/gtk/main.c:70
> > +    GError* error = NULL;
> 
> Ditto. Please use 0 here instead of NULL.
> 
> > Tools/MiniBrowser/gtk/main.c:81
> > +        gint i;
> 
> Please just use int here.

Ok, Thanks. Note that this depends on uncommitted not yet approved patches, so I'll push it as soon as other patches are committed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.