[Webkit-unassigned] [Bug 58416] [GTK] Implement UI client in minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58416


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89760|review?                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-04-26 16:19:42 PST ---
(From update of attachment 89760)
View in context: https://bugs.webkit.org/attachment.cgi?id=89760&action=review

Looks good, but please fix the style errors before landing.

> Tools/MiniBrowser/gtk/BrowserWindow.c:406
> +static void browserWindowUIClientInit(BrowserWindow* window)

Please shift the asterisk over.

> Tools/MiniBrowser/gtk/main.c:32
> +static const gchar** uriArguments = NULL;

The asterisks should be on uriArguments.

> Tools/MiniBrowser/gtk/main.c:48
> +    GtkWidget* mainWindow = browser_window_new(webView);
> +    gchar* url = argumentToURL(uri);
> +    WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithUTF8CString(url));

Ditto

> Tools/MiniBrowser/gtk/main.c:66
> +    GOptionContext* context = g_option_context_new(NULL);

Ditto

> Tools/MiniBrowser/gtk/main.c:70
> +    GError* error = NULL;

Ditto. Please use 0 here instead of NULL.

> Tools/MiniBrowser/gtk/main.c:81
> +        gint i;

Please just use int here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.