[Webkit-unassigned] [Bug 50949] Add support for unicode-bidi:plaintext CSS property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50949





--- Comment #8 from Levi Weintraub <leviw at chromium.org>  2011-04-26 16:30:50 PST ---
(From update of attachment 88417)
View in context: https://bugs.webkit.org/attachment.cgi?id=88417&action=review

>> Source/WebCore/html/HTMLElement.cpp:170
>> +        addCSSProperty(attr, CSSPropertyUnicodeBidi, bidiAttribute);
> 
> This is a super-weird place for this code!  I guess since I we have eto leave his here we should abstract this into a unicodeBidFromDirAuto() helper.

That makes sense.

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:87
>> +{
> 
> So this is basically "first strong direction in paragarph"?  I'm not sure where this logic goes.

That's correct. First the first character with a strong directionality is what determines the paragraph's base writing direction.

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1266
>> +            determineParagraphDirection(direction, InlineIterator(this, bidiFirst(this, 0), pos));
> 
> I think we're going to want to start passing unicodeBidi() to BidiContexts :(
> 
> Are we sure this is the only place this needs to be done?

These two cases cover it: when we initially set up the BidiContext for the block, and again after each paragraph separator.

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1270
>> +        resolver.setContext(BidiContext::create(direction == LeftToRight ? 0 : 1, direction, style()->unicodeBidi() == Override, FromStyleOrDOM));
> 
> I think I have an outstanding conflicting patch here.

Link? If it's going to be a blocking issue list it as such so I know when to update this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.