[Webkit-unassigned] [Bug 50949] Add support for unicode-bidi:plaintext CSS property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50949


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88417|review?                     |review-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2011-04-26 16:08:59 PST ---
(From update of attachment 88417)
View in context: https://bugs.webkit.org/attachment.cgi?id=88417&action=review

I'm concerned this is not the only place you want this code.  Otherwise seems fine.

> Source/WebCore/html/HTMLElement.cpp:170
> +        int bidiAttribute;
> +        if (hasLocalName(bdoTag))
> +            bidiAttribute = CSSValueBidiOverride;
> +        else if (hasLocalName(preTag) || hasLocalName(textareaTag))
> +            bidiAttribute = CSSValueWebkitPlaintext;
> +        else
> +            bidiAttribute = CSSValueEmbed;
> +        addCSSProperty(attr, CSSPropertyUnicodeBidi, bidiAttribute);

This is a super-weird place for this code!  I guess since I we have eto leave his here we should abstract this into a unicodeBidFromDirAuto() helper.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:87
> +static void determineParagraphDirection(Direction& dir, InlineIterator iter)
> +{

So this is basically "first strong direction in paragarph"?  I'm not sure where this logic goes.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1266
> +        if (style()->unicodeBidi() == Plaintext)
> +            determineParagraphDirection(direction, InlineIterator(this, bidiFirst(this, 0), pos));

I think we're going to want to start passing unicodeBidi() to BidiContexts :(

Are we sure this is the only place this needs to be done?

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1270
>          resolver.setLastStrongDir(direction);
>          resolver.setLastDir(direction);
>          resolver.setEorDir(direction);
> -        resolver.setContext(BidiContext::create(ltr ? 0 : 1, direction, style()->unicodeBidi() == Override, FromStyleOrDOM));
> +        resolver.setContext(BidiContext::create(direction == LeftToRight ? 0 : 1, direction, style()->unicodeBidi() == Override, FromStyleOrDOM));

I think I have an outstanding conflicting patch here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.