[Webkit-unassigned] [Bug 48074] [Cairo] Text underline is not shadowed when text-shadow is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48074


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84137|review?                     |review-
               Flag|                            |




--- Comment #6 from Dirk Schulze <krit at webkit.org>  2011-04-26 15:57:09 PST ---
(From update of attachment 84137)
View in context: https://bugs.webkit.org/attachment.cgi?id=84137&action=review

I'd like to see it a second time.

> Source/WebCore/platform/graphics/GraphicsContext.h:509
> +

Remove this line

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:326
> +    bool isVerticalLine = (point1.x() == point2.x());

avoid the braces

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:431
> +        patternWidth = floor(strokeThickness() / 2.f);

floorf, but depends what strokeThickness returns. please check this.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:434
> +        patternWidth = 3 * floor(strokeThickness() / 2.f);

ditto

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:445
> +            distance = floor((piFloat * hRadius) / 2.0);

floorf

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:447
> +            distance = floor((piFloat * sqrtf((hRadius * hRadius + vRadius * vRadius) / 2.0)) / 2.0);

ditto

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:448
> +        double patternOffset = calculateStrokePatternOffset(distance, patternWidth);

if patternOffset is double, you should may use double in general and ignore the last two comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.