[Webkit-unassigned] [Bug 48074] [Cairo] Text underline is not shadowed when text-shadow is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48074





--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-04-27 12:40:34 PST ---
(In reply to comment #6)
> (From update of attachment 84137 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84137&action=review


> I'd like to see it a second time.
Thank you kindly for the review.

> > Source/WebCore/platform/graphics/GraphicsContext.h:509
> > +
> Remove this line

Done.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:326
> > +    bool isVerticalLine = (point1.x() == point2.x());
> avoid the braces

Done.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:431
> > +        patternWidth = floor(strokeThickness() / 2.f);
> floorf, but depends what strokeThickness returns. please check this.
> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:434
> > +        patternWidth = 3 * floor(strokeThickness() / 2.f);
> ditto
> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:445
> > +            distance = floor((piFloat * hRadius) / 2.0);
> floorf
> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:447
> > +            distance = floor((piFloat * sqrtf((hRadius * hRadius + vRadius * vRadius) / 2.0)) / 2.0);
> ditto

Done!

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:448
> > +        double patternOffset = calculateStrokePatternOffset(distance, patternWidth);
> if patternOffset is double, you should may use double in general and ignore the last two comments.

I've changed distance to a florat moved the floorf here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.