[Webkit-unassigned] [Bug 59234] CrossThreadCopier should not have a default specialization for raw pointers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59234





--- Comment #3 from Dmitry Lomov <dslomov at google.com>  2011-04-25 09:51:28 PST ---
(In reply to comment #2)
> (From update of attachment 90764 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90764&action=review
> 
> In general, I think this is a great change!
> 
>  I think we should think about the names a bit more.
> 
> Also putting the extended life time stuff into the CrossThreadCopier.h doesn't quite fit with theme of that file.

The real problem is not that we have something related to extended lifetime in CrossThreadCopier, but the fact that CrossThreadCopier is required where no cross-thread communication happen! 

Viz, in FileReader and in SQLCallbackWrapper, the posted tasks are guaranteed to execute on the _same_ thread, and implementation throughout relies on this fact heavily (mutates objects without any synchronization). If we statically type our threading assumptions, we should distinguish between true cross-thread (i.e. parallel) access and "co-routine style" access. I think they should be different kinds of CallbackTasks, coroutine one just passing everything via RefPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.