[Webkit-unassigned] [Bug 59234] CrossThreadCopier should not have a default specialization for raw pointers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59234





--- Comment #2 from David Levin <levin at chromium.org>  2011-04-24 22:28:35 PST ---
(From update of attachment 90764)
View in context: https://bugs.webkit.org/attachment.cgi?id=90764&action=review

In general, I think this is a great change!

 I think we should think about the names a bit more.

Also putting the extended life time stuff into the CrossThreadCopier.h doesn't quite fit with theme of that file.

Some other minor comments below.

> Source/WebCore/ChangeLog:4
> +

Bug title should be here.

> Source/WebCore/fileapi/FileStreamProxy.cpp:140
> +    fileThread()->postTask(

Please undo this change since nothing is being done here except reformatting.

> Source/WebCore/fileapi/FileStreamProxy.cpp:153
> +    fileThread()->postTask(

Ditto.

> Source/WebCore/fileapi/FileStreamProxy.cpp:166
> +    fileThread()->postTask(

Ditto.

> Source/WebCore/fileapi/FileStreamProxy.cpp:204
> +        createFileThreadTask(this,

Ditto.

> Source/WebCore/fileapi/FileStreamProxy.cpp:223
> +        createFileThreadTask(this,

Ditto.

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:90
> +          createCallbackTask(&IDBObjectStoreBackendImpl::getInternal,

Ditto.

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:139
> +            createCallbackTask(&IDBObjectStoreBackendImpl::putInternal,

Ditto.

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:289
> +            createCallbackTask(&IDBObjectStoreBackendImpl::deleteInternal,

Ditto.

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:325
> +              createCallbackTask(&IDBObjectStoreBackendImpl::clearInternal,

Ditto and many other places. (I'm tired of putting in ditto :) ).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.