[Webkit-unassigned] [Bug 59028] Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59028





--- Comment #4 from Igor Trindade Oliveira <itrindade.oliveira at gmail.com>  2011-04-21 12:52:44 PST ---
(In reply to comment #3)
> (From update of attachment 90509 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90509&action=review
> 
> > Source/WebCore/dom/DataTransferItem.h:36
> > +#include "Clipboard.h"
> 
> I think forward declarations are preferred in header files where possible (same comment in DataTransferItems.h)

Ok. Fixing that.

> 
> > Source/WebCore/dom/DataTransferItem.h:49
> > +    static PassRefPtr<DataTransferItem> create(PassRefPtr<Clipboard> owner, ScriptExecutionContext*, const String& data, const String& type);
> 
> I'm not sure how useful it is to hoist this method up into the shared implementation. Is there somewhere in the shared implementation that would call this? If not, I think it would be better to leave this method on the platform implementations. That way, we don't have to expose internal enums publicly.

The DataTransferItems.cpp is using this method, take a look in DataTransferItems::add (  m_items.append(DataTransferItem::create(m_owner, m_context, data, type)); )
. I can try to find a better solution.
> 
> > Source/WebCore/dom/DataTransferItem.h:62
> > +    void setKind(const String&);
> 
> Who uses these setters?

Right now, nobody :) , i just added it because in future some platform can use this setter. But i do not have objections to remove these setters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.