[Webkit-unassigned] [Bug 59028] Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59028





--- Comment #3 from Daniel Cheng <dcheng at chromium.org>  2011-04-21 12:32:39 PST ---
(From update of attachment 90509)
View in context: https://bugs.webkit.org/attachment.cgi?id=90509&action=review

> Source/WebCore/dom/DataTransferItem.h:36
> +#include "Clipboard.h"

I think forward declarations are preferred in header files where possible (same comment in DataTransferItems.h)

> Source/WebCore/dom/DataTransferItem.h:49
> +    static PassRefPtr<DataTransferItem> create(PassRefPtr<Clipboard> owner, ScriptExecutionContext*, const String& data, const String& type);

I'm not sure how useful it is to hoist this method up into the shared implementation. Is there somewhere in the shared implementation that would call this? If not, I think it would be better to leave this method on the platform implementations. That way, we don't have to expose internal enums publicly.

> Source/WebCore/dom/DataTransferItem.h:62
> +    void setKind(const String&);

Who uses these setters?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.