[Webkit-unassigned] [Bug 59026] RenderLayers mutate the GraphicsLayer tree during GraphicsLayerClient::paintContents callback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59026





--- Comment #2 from James Robinson <jamesr at chromium.org>  2011-04-20 17:25:51 PST ---
(In reply to comment #1)
> What's more interesting are stacks where the z-order lists are dirtied during painting.

I don't think the z-order lists are being dirtied during painting, but they can definitely be dirty when calling paintLayer() on some composited layer and updating the z-order lists can cause the compositing requirements to change.  In the software rendering path, updating the z-order list for a RenderLayer is fine so long as it completes before iterating into any children of the RenderLayer, but in the compositing case it can cause the compositing requirements to change in weird ways.

If I understand correctly we want to build the z-order lists lazily (since we don't need them for normal layout, just rendering), but we definitely need them before painting.  I think the best solution here is to add a call to rebuild the z-order lists for all RenderLayers in the tree that the compositor can invoke before it calls paintContents() for any GraphicsLayers in the tree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.