[Webkit-unassigned] [Bug 58818] [GTK] fast/block/float/overhanging-tall-block.html crashes in the bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58818


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-04-20 12:13:44 PST ---
(In reply to comment #5)
> (From update of attachment 90219 [details])
> 
> Looks goods! Just a couple of comments.
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=90219&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Prevent allocating scratch buffers larger than the target GdkDarawable
> 
> GdkDrawable

Fixed!

> Should we inflate first and later shrunkTo?

inflate() modifies the offset of the target rectangle. If we inflate first and then shrink, there would have to be more code which detected if the offset needs to be corrected after shrunkTo. It seemed simpler to inflate later, since there isn't much harm in having a buffer that is 30 pixels bigger in each direction. We're really just trying to prevent having buffer that is much bigger than the target.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.