[Webkit-unassigned] [Bug 58818] [GTK] fast/block/float/overhanging-tall-block.html crashes in the bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58818





--- Comment #5 from Alejandro G. Castro <alex at igalia.com>  2011-04-20 05:34:02 PST ---
(From update of attachment 90219)

Looks goods! Just a couple of comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=90219&action=review

> Source/WebCore/ChangeLog:8
> +        Prevent allocating scratch buffers larger than the target GdkDarawable

GdkDrawable

> Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:93
> +    // We never want to create a scratch buffer larger than the size of our target GdkDrawable.
> +    // This prevents giant pixmap allocations for very large widgets in smaller views.
> +    int maxWidth = 0, maxHeight = 0;
> +    gdk_drawable_get_size(graphicsContext->gdkWindow(), &maxWidth, &maxHeight);
> +    m_targetRect.setSize(m_targetRect.size().shrunkTo(IntSize(maxWidth, maxHeight)));
> +
>      // Widgets sometimes need to draw outside their boundaries for things such as
>      // exterior focus. We want to allocate a some extra pixels in our surface for this.
> -    m_extraSpace = IntSize(15, 15);
> +    static int extraSpace = 15;
> +    m_targetRect.inflate(extraSpace);

Should we inflate first and later shrunkTo?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.