[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #14 from Levi Weintraub <leviw at chromium.org>  2011-04-19 12:04:09 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=90155&action=review

I'm having trouble determining how exactly uncommitedWidth differs from additionalWidth. It seems to me that additionalWidth is really more like uncommittedTextWidth (at least as implemented in this patch), and while I have my theories about why this is the right fix, I'd like a better description as to why in the changelog.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1779
> +                if (floatsFitOnLine && width.fitsOnLine(logicalWidthForFloat(f) - width.additionalWidth())) {

Could we instead have a different version of fitsOnLine that wraps this up for us? Perhaps fitsOnLineOverridingText? Or floatFitsOnLine? This change doesn't self-document well.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2129
> +            if (!ignoringSpaces && additionalTmpW)

At least the !ignoringSpaces part is redundant since additionalTmpW is only nonzero when !ignoringSpaces.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.