[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #15 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2011-04-20 00:23:45 PST ---
(In reply to comment #14)
> I'm having trouble determining how exactly uncommitedWidth differs from additionalWidth. It seems to me that additionalWidth is really more like uncommittedTextWidth (at least as implemented in this patch), and while I have my theories about why this is the right fix, I'd like a better description as to why in the changelog.

If there are more than 2 spaces between "Float" and "Breaking" in TC, uncommittedWidth would be different from additionalWidth.
uncommittedWidth and additionalWidth might be same for first empty space, but  uncommittedWidth is commited and we set ignoringSpaces=true from second spaces.
In this situation, uncommittedWidth would be zero, when checking float fits on line.
I've tried to update ChangLog in detail.

> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1779
> > +                if (floatsFitOnLine && width.fitsOnLine(logicalWidthForFloat(f) - width.additionalWidth())) {
> 
> Could we instead have a different version of fitsOnLine that wraps this up for us? Perhaps fitsOnLineOverridingText? Or floatFitsOnLine? This change doesn't self-document well.
Yeh. floatFitsOnLine seems proper to me. :)


> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2129
> > +            if (!ignoringSpaces && additionalTmpW)
> 
> At least the !ignoringSpaces part is redundant since additionalTmpW is only nonzero when !ignoringSpaces.
I was confused. :p My intention is currentCharacterIsSpace.

Thanks for your comment! :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.