[Webkit-unassigned] [Bug 45662] Web Inspector: [Resources panel] Should be easy to copy data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45662


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89893|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2011-04-18 02:18:31 PST ---
(From update of attachment 89893)
View in context: https://bugs.webkit.org/attachment.cgi?id=89893&action=review

Overall looks good. You need an entry in localizedStrings.js as Yury suggests to land this.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1023
>          InspectorFrontendHost.copyText(JSON.stringify(har));

It used to export values, now it copies them, so the name of the method is misleading. Do not reuse it.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1026
> +    _exportLocation: function(resource)

I.e. should be _copyLocation, etc.

> Source/WebCore/inspector/front-end/Resource.js:429
> +            this._requestHeadersText += key + ": " + this.requestHeaders[key] + '\n'; 

Please use double quotes.

> Source/WebCore/inspector/front-end/Resource.js:510
> +            this._responseHeadersText += key + ": " + this.responseHeaders[key] + '\n'; 

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.