[Webkit-unassigned] [Bug 45662] Web Inspector: [Resources panel] Should be easy to copy data.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 18:28:56 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=45662





--- Comment #4 from Annie Sullivan <sullivan at chromium.org>  2011-04-21 18:28:56 PST ---
(From update of attachment 89893)
View in context: https://bugs.webkit.org/attachment.cgi?id=89893&action=review

>> Source/WebCore/inspector/front-end/NetworkPanel.js:1023
>>          InspectorFrontendHost.copyText(JSON.stringify(har));
> 
> It used to export values, now it copies them, so the name of the method is misleading. Do not reuse it.

Done.

>> Source/WebCore/inspector/front-end/NetworkPanel.js:1026
>> +    _exportLocation: function(resource)
> 
> I.e. should be _copyLocation, etc.

Done.

>> Source/WebCore/inspector/front-end/Resource.js:429
>> +            this._requestHeadersText += key + ": " + this.requestHeaders[key] + '\n'; 
> 
> Please use double quotes.

Done.

>> Source/WebCore/inspector/front-end/Resource.js:510
>> +            this._responseHeadersText += key + ": " + this.responseHeaders[key] + '\n'; 
> 
> ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list